feat(remix-testing): cast types to use Remix type definitions + allow passing context #6065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before if you tried to pass a loader/action directly to the route object it would fail as
context
is optional in RR, but required in Remix (types for each are also different, bug would remain if required), so you would have to manually passcontext: {}
now we're using the Remix types for loader/action, but we need to cast them on the way out back to RR for use with
createMemoryRouter
this PR also introduces the ability to pass
context
to your stubbed loaders/actions via a second argument tocreateRemixStub
closes #6054
Testing Strategy: new tests