Remove v2_normalizeFormMethod #5905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fe3b775 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Mar 24, 2023
| | `v2_normalizeFormMethod` | Normalize `useNavigation().formMethod` to be an uppercase HTTP Method | | ||
| | `v2_routeConvention` | Enable the flat routes style of file-based routing | | ||
|
|
||
| We're in the process of preparing for our v2 release, so all `future.unstable_` flags are being stabilized into `future.v2_` flags (except for those which are not breaking changes, like PostCSS/Tailwind/Vanilla Extract support). This includes adding deprecation warnings for apps still using the old way. Once we stabilize them all we'll do a final Remix 1.15.0 release and let that run for a bit to give folks time to opt into any flags they haven't yet added. Then we'll plan to release Remix 2.0.0 and start working on releasing flag-driven Remix v3 features. |
There was a problem hiding this comment.
I removed all v2 flags from this branch since they're all gone now as well as this paragraph about 1.15.0/v2
brophdawg11
commented
Mar 24, 2023
| @@ -1049,97 +1039,6 @@ export function useActionData<T = AppData>(): SerializeFrom<T> | undefined { | |||
| return useActionDataRR() as SerializeFrom<T> | undefined; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Bye bye back-compat layer 👋
mcansh
approved these changes
Mar 24, 2023
jacob-ebey
reviewed
Mar 24, 2023
| @@ -21,6 +23,8 @@ export { | |||
| useAsyncValue, | |||
| isRouteErrorResponse, | |||
| useBeforeUnload, | |||
| useFetcher, | |||
There was a problem hiding this comment.
Do we have generic typings over in RR now on useFetcher?
There was a problem hiding this comment.
MichaelDeBoey
added
the
BREAKING CHANGE
MichaelDeBoey
added a commit
that referenced
this pull request
Jul 10, 2023
Co-authored-by: Michaël De Boey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
v2_normalizeFormMethodflag for v2