-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix-server-runtime): pass AppLoadContext
to handleRequest
#5836
feat(remix-server-runtime): pass AppLoadContext
to handleRequest
#5836
Conversation
🦋 Changeset detectedLatest commit: 131a1c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @fernandojbf, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
6c4146c
to
4769f1b
Compare
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
cdb1066
to
be5dc39
Compare
Bahh, I've made a rebase from main :( i will fix that in a moment |
be5dc39
to
2b1c91f
Compare
Rebased again :) |
AppLoadContext
to handleRequest
2b1c91f
to
1df3065
Compare
I, too, would like to see the PR merged. I think it was an oversight in the initial implementation. The other |
Thank you 🎉 |
Thank YOU! :) |
This is the same feature change request done here. A new discussion was created to this.
My action was mainly check the changes by introduced @axel-habermaier's PR and apply them again.
This is my first contribution, if i made something wrong please let me know.
Closes: #
Testing Strategy:
I've added unit tests on server-runtime passing loadContext to the handler.