Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev): use path.resolve when re-exporting entry.client #5707

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Mar 8, 2023

fixes an issue when using @remix-run/css-bundle in a monorepo.

no integration tests as i don't think we can do that with our current test infra

Closes: #5659

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2023

🦋 Changeset detected

Latest commit: e34582e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcansh mcansh linked an issue Mar 8, 2023 that may be closed by this pull request
1 task
@wesleygrimes
Copy link

Do you think it would be possible for this to go out in the next release: 1.14.2?

@mcansh mcansh changed the title fix(remix-dev): use path.resolve when re-exporting entry fix(remix-dev): use path.resolve when re-exporting entry.client Mar 13, 2023
@mcansh mcansh merged commit 6938535 into dev Mar 13, 2023
@mcansh mcansh deleted the logan/5659 branch March 13, 2023 14:01
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Mar 13, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-bf9d0a9-20230314 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS bundling fails without entry.client.tsx and entry.server.tsx in a monorepo
3 participants