Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional entry.{client,server} for react 17 #5681

Merged
merged 12 commits into from
Mar 21, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Mar 6, 2023

Closes: #5669
Closes: #5810

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2023

🦋 Changeset detected

Latest commit: e249cd5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcansh mcansh force-pushed the logan/optional-entries-react-17 branch from 22447e8 to b635550 Compare March 6, 2023 22:17
@mcansh mcansh force-pushed the logan/optional-entries-react-17 branch from 56c3868 to 82603a2 Compare March 6, 2023 23:25
@mcansh mcansh marked this pull request as ready for review March 7, 2023 16:18
@mcansh mcansh force-pushed the logan/optional-entries-react-17 branch from 42a8cae to 126ece6 Compare March 7, 2023 16:25
packages/remix-dev/config.ts Outdated Show resolved Hide resolved
packages/remix-dev/config.ts Outdated Show resolved Hide resolved
packages/remix-dev/config.ts Outdated Show resolved Hide resolved
packages/remix-dev/config.ts Outdated Show resolved Hide resolved
packages/remix-dev/config.ts Outdated Show resolved Hide resolved
packages/remix-dev/cli/commands.ts Outdated Show resolved Hide resolved
packages/remix-dev/cli/commands.ts Outdated Show resolved Hide resolved
Co-authored-by: Michaël De Boey <[email protected]>

Signed-off-by: Logan McAnsh <[email protected]>
@mcansh mcansh force-pushed the logan/optional-entries-react-17 branch from c2313c6 to 9125fb7 Compare March 7, 2023 17:10
@mcansh mcansh linked an issue Mar 10, 2023 that may be closed by this pull request
1 task
@mcansh mcansh self-assigned this Mar 14, 2023
@mcansh mcansh force-pushed the logan/optional-entries-react-17 branch from 9125fb7 to b50df31 Compare March 15, 2023 14:50
@mcansh mcansh linked an issue Mar 15, 2023 that may be closed by this pull request
@ZackWard
Copy link

@mcansh I just discovered this change (optional entry files) today and found it pretty confusing. I would like to propose that along with this change, the prominent docs/file-conventions/entry.client.md and docs/file-conventions/entry.server.md files be updated to clarify that users should not expect to see these files by default.

@mcansh mcansh force-pushed the logan/optional-entries-react-17 branch from b50df31 to f42374c Compare March 17, 2023 15:57
@mcansh mcansh merged commit 84efa0a into dev Mar 21, 2023
@mcansh mcansh deleted the logan/optional-entries-react-17 branch March 21, 2023 18:19
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Mar 21, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-d6c9737-20230322 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional entries don't work with React 17 Removing entry.client & entry.server causes remix dev to hang
4 participants