Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-dev): allow bundler as moduleResolution in tsconfig.json #5576

Merged
merged 3 commits into from
Mar 4, 2023
Merged

feat(remix-dev): allow bundler as moduleResolution in tsconfig.json #5576

merged 3 commits into from
Mar 4, 2023

Conversation

buzinas
Copy link
Contributor

@buzinas buzinas commented Feb 26, 2023

See https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#moduleresolution-bundler for more info.

  • Docs (I don't think there is anything relevant to add to the docs, please let me know otherwise).
  • Tests

Testing Strategy:

I've been patching this since I moved to TypeScript v5 beta. I also added a unit test.

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2023

🦋 Changeset detected

Latest commit: 87c1447

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Minor
create-remix Minor
@remix-run/css-bundle Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor
@remix-run/vercel Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 26, 2023

Hi @buzinas,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 26, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@buzinas buzinas changed the base branch from main to dev February 26, 2023 14:06
@buzinas
Copy link
Contributor Author

buzinas commented Mar 4, 2023

Can someone review this? It's a one-liner, and I hope it doesn't get lost for months like #1207 and #4401 did.

@pcattori @mcansh @jacob-ebey

@mcansh mcansh merged commit f218b33 into remix-run:dev Mar 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-f218b33-20230305 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@MichaelDeBoey MichaelDeBoey changed the title Allow TypeScript v5 moduleResolution: "bundler" feat(remix-dev): allow bundler as moduleResolution in tsconfig.json Mar 5, 2023
@buzinas buzinas deleted the module-resolution-bundler branch April 30, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants