-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-dev): normalize /route
routeId, update route collision warnings
#5459
Conversation
🦋 Changeset detectedLatest commit: e8447f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ac27288
to
49b50ae
Compare
49b50ae
to
6c84533
Compare
Signed-off-by: Logan McAnsh <[email protected]>
e25a031
to
c74e086
Compare
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
"products/:pid" & "products/:productId" Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
/route
routeId/route
routeId, update route collision warnings
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
1f54d06
to
f0fbdb2
Compare
… update test infra Signed-off-by: Logan McAnsh <[email protected]>
a702ac6
to
92f9669
Compare
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look at the code, just the tests and it looks great :)
Signed-off-by: Logan McAnsh <[email protected]>
Signed-off-by: Logan McAnsh <[email protected]>
🤖 Hello there, We just published version Thanks! |
updates some missed logic so
<dir>/route
no longer conflicts in some cases.updates conflict logic so it no longer throws errors and instead displays a nice error message about your conflicts
Closes: #5470
Closes: #5471
Closes: #5495
Testing Strategy: