Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: log errors during initial build in development #5441

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Feb 13, 2023

The onCompileFailure was not passed to the compile function so errors were not logged during initial build in dev.

It is passed to createRemixCompiler instead but it doesn't seem to be used there, so perhaps you want to remove it.

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2023

🦋 Changeset detected

Latest commit: 0b0bfa5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori merged commit b44b932 into remix-run:dev Feb 14, 2023
@frandiox frandiox deleted the fd-log-errors-initial-build branch February 15, 2023 05:58
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-b44b932-20230215 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants