Fix adapter request creation when double slashes exist #5336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of this came down to us passing the origin in the optional second
base
param for thenew URL()
constructor. When we did this, an incoming pathname of//
got incorrectly identified as a protocol-less absolute URL. Since we know the origin, we can just pass an absolute URL directly into the first param to avoid this:Closes: #4422
Replace #4622
DocsTesting Strategy:
//
will match a root/index route//todos
will 404 if a/todos
route exists