Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support decorators with CSS side-effects #5305

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

markdalgleish
Copy link
Member

Closes: #5287

  • Docs
  • Tests

Testing Strategy:

I've added snapshot tests that exercise a bunch of language features for all combinations of JS/TS with and without JSX. I wanted to make sure there weren't other obvious cases we weren't handling, but I also wanted to provide a place to add further test cases in the future.

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2023

🦋 Changeset detected

Latest commit: b359087

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish removed the request for review from chaance January 30, 2023 02:22
@markdalgleish
Copy link
Member Author

@MichaelDeBoey Thanks for the review!

@markdalgleish markdalgleish merged commit 52284ab into dev Jan 30, 2023
@markdalgleish markdalgleish deleted the markdalgleish/css-side-effects-decorators branch January 30, 2023 02:22
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 30, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-52284ab-20230130 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@ryanwilsonperkin
Copy link

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants