Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel config to transpile down to node 14 #5047

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

brophdawg11
Copy link
Contributor

Closes #5043

To test, run yarn build and look at build/node_modules/@remix-run/react/dist/components.js and confirm that around line 108 you don't see any ||= operators.

Here's the diff between a 1.10.0 build and a build on this branch:

~/me/shopify/repos/remix (brophdawg11/node-14-build)> diff -r build-current build
diff -r build-current/node_modules/@remix-run/react/dist/components.js build/node_modules/@remix-run/react/dist/components.js
109,110c109,110
<     CatchBoundary ||= errorBoundaries.RemixRootDefaultCatchBoundary;
<     ErrorBoundary ||= errorBoundaries.RemixRootDefaultErrorBoundary;
---
>     CatchBoundary || (CatchBoundary = errorBoundaries.RemixRootDefaultCatchBoundary);
>     ErrorBoundary || (ErrorBoundary = errorBoundaries.RemixRootDefaultErrorBoundary);
diff -r build-current/node_modules/@remix-run/react/dist/esm/components.js build/node_modules/@remix-run/react/dist/esm/components.js
85,86c85,86
<     CatchBoundary ||= RemixRootDefaultCatchBoundary;
<     ErrorBoundary ||= RemixRootDefaultErrorBoundary;
---
>     CatchBoundary || (CatchBoundary = RemixRootDefaultCatchBoundary);
>     ErrorBoundary || (ErrorBoundary = RemixRootDefaultErrorBoundary);

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2023

🦋 Changeset detected

Latest commit: 2ec4fcf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Jan 10, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of hammer operator crashes on node 14
5 participants