Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(remix-dev): add file extensions to compiler/loaders #5030

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

staylor
Copy link
Contributor

@staylor staylor commented Jan 9, 2023

Closes #5019

These extensions are used on some routes on the Shopify website.

Testing Strategy:

Try importing a .mov file - a URL should be returned, instead of a loader error.

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2023

🦋 Changeset detected

Latest commit: 151b995

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Minor
create-remix Minor
@remix-run/css-bundle Patch
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor
@remix-run/vercel Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 9, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@mcansh mcansh changed the title Add file extensions to compiler/loaders chore(remix-dev): add file extensions to compiler/loaders Jan 9, 2023
@ryanflorence ryanflorence merged commit 3eeb9be into remix-run:dev Jan 11, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.10.1-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-d371904-20230112 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.10.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some file extensions are missing in compiler/loaders
5 participants