feat(react,server-runtime): Support for v2 array syntax for route meta
#4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v2 `meta` API can now be supported behind a future flag. See https://github.com/orgs/remix-run/projects/5/views/1?filterQuery=meta for details.
🦋 Changeset detectedLatest commit: 4b84867 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
machour
reviewed
Nov 17, 2022
jacob-ebey
approved these changes
Nov 18, 2022
machour
approved these changes
Nov 18, 2022
github-actions
bot
added
the
awaiting release
This was referenced Nov 19, 2022
kentcdodds
pushed a commit
that referenced
this pull request
Dec 15, 2022
… `meta` (#4610) The v2 `meta` API can now be supported behind a future flag. See https://github.com/orgs/remix-run/projects/5/views/1?filterQuery=meta for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation for #4462.
Closes: #2598
Note: The types here are not complete and not ideal, but we are running into a wall with our current approach of copy-paste-all-the-types because we lack a shared dependency, and continuing down that path will make it even harder to fix. We are prioritizing a solution to that in a separate proposal and providing minimal (but sufficient) types in the mean time.
Also, docs will come in a separate PR because I'd like us to kick the tires on it a bit before documenting the change. This is fine since it's completely opt-in anyway.