feat(remix-dev): make entry.{client,server}.tsx optional

[mcansh]

made this before making a proposal like a dummy, but it's something we've talked about a bit internally

proposal here 👉 #4601

follow PR to make remix config optional 🎉

edit on the optional remix config.. turns out that already works as we check before we attempt to load it.

remix/packages/remix-dev/config.ts

Lines 321 to 343 in 611c68b

	let configFile = findConfig(rootDirectory, "remix.config");
	let appConfig: AppConfig = {};
	if (configFile) {
	let appConfigModule: any;
	try {
	// shout out to next
	// https://github.com/vercel/next.js/blob/b15a976e11bf1dc867c241a4c1734757427d609c/packages/next/server/config.ts#L748-L765
	if (process.env.NODE_ENV === "test") {
	// dynamic import does not currently work inside of vm which
	// jest relies on so we fall back to require for this case
	// https://github.com/nodejs/node/issues/35889
	appConfigModule = require(configFile);
	} else {
	appConfigModule = await import(pathToFileURL(configFile).href);
	}
	appConfig = appConfigModule?.default || appConfigModule;
	} catch (error: unknown) {
	throw new Error(
	`Error loading Remix config at ${configFile}\n${String(error)}`
	);
	}
	}

Signed-off-by: Logan McAnsh [email protected]

Closes: #

• Docs
• Tests

Testing Strategy:

[changeset-bot]

🦋 Changeset detected

Latest commit: a7661fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
remix	Minor
@remix-run/dev	Minor
create-remix	Minor
@remix-run/css-bundle	Minor
@remix-run/architect	Minor
@remix-run/cloudflare	Minor
@remix-run/cloudflare-pages	Minor
@remix-run/cloudflare-workers	Minor
@remix-run/deno	Minor
@remix-run/eslint-config	Minor
@remix-run/express	Minor
@remix-run/netlify	Minor
@remix-run/node	Minor
@remix-run/react	Minor
@remix-run/serve	Minor
@remix-run/server-runtime	Minor
@remix-run/testing	Minor
@remix-run/vercel	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[MichaelDeBoey]

What about people using JS instead of TS?
Do they need to have this file in their repo if they never changed it?

Should we also remove these files from our templates/examples?

[MichaelDeBoey]

I think we should also run the JS migration on the file when people choose the js/jsx extension in the generator command?

[mcansh]

I think we should also run the JS migration on the file when people choose the js/jsx extension in the generator command?

definitely, this is still very much WIP. it also needs to go through the RFC phase as the og proposal was sort of just thrown together

[mcansh]

What about people using JS instead of TS?

if they "eject" we'll transform it to js

Do they need to have this file in their repo if they never changed it?

doesn't hurt

Should we also remove these files from our templates/examples?

that's up for debate, templates would get any update faster than it being bundled in the CLI (unless we hit GitHub to get the file and use the bundled one if they're offline)

[MichaelDeBoey]

This will stop working whenever we remove the explicit need of a runtime and we import everything from the adapter & separate server package (for functions like json & redirect)

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-ecba23c-20230211 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!