feat(remix-server-runtime): RRR 1.3 / 1.4 - handleDocumentRequest #4385
Conversation
🦋 Changeset detectedLatest commit: ccae87f The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
add missing type import
test: stop compiler test from logging
test: revert mdx test to cover failure case
|
Just curious, what's this going to do? Remix already serves document requests for SSR so I suppose is another thing |
|
@brophdawg11 is there a decision doc for this work? Would help me follow along |
|
@machour Yep! https://github.com/remix-run/remix/blob/main/decisions/0007-remix-on-react-router-6-4-0.md - this PR is steps |
chore: update tests to handle no assert flow
|
Need to add a changeset to describe the changes in error/catch boundary behaviors in Remix. Merging this PR will enable those even without the flag enabled. |
|
I think this is good to go now? Let's touch base with @chaance and make sure that we're good to merge this (since he already cut the |
jacob-ebey
changed the title
jacob-ebey
changed the title
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
) test: update test to be more reliable chore: be more protective when accessing route module test: stop compiler test from logging feat: disambiguate catch/error boundary responses fix: ensure route modules are loaded regardless of error state test: make fetcher tests more reliable feat: Change missing loader from 405 -> 400 error Co-authored-by: Matt Brophy <[email protected]>
decision doc
Part 3 and 4 of step 1 in layering Remix back on top of React Router now that we have released
@remix-run/router.Changes:
Closes: #
Testing Strategy:
Assert that existing tests pass and manually check new code is not in non-experimental production builds.