-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-dev): Update create-remix to use the new examples repository #4208
fix(remix-dev): Update create-remix to use the new examples repository #4208
Conversation
🦋 Changeset detectedLatest commit: e241c5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I'm hitting a snag here: My changes to Any guidance would be appreciated :) |
Thanks @machour, I'll take a look at this tomorrow and see if I can help with the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pressed approve too early—looks like we've got some failing test cases here. Let's get those patched up and I'll merge this for the next release.
Also: could we add a changeset noting the bug fix since this is broken at the moment?
@chaance You were supposed to help for the tests 😅 (see your previous reply) As commented, the problem is that tests were mocking the request to Now that we moved examples to their own repository, this mock isn't usable anymore. I suppose I'll have to create a Can someone guide me, or take over this last step from me? (I'll understand what I was missing from the diff) |
6c2932e
to
f2d25bc
Compare
@machour looking at it this morning! |
taking a look into this now :) |
Signed-off-by: Logan McAnsh <[email protected]>
Thank you @mcansh ! |
LGTM! @machour |
🤖 Hello there, We just published version Thanks! |
Also removed some now obsolete eslint rules