Skip to content

refactor(examples/firebase-auth-firestore): rename to firebase#4058

Merged
MichaelDeBoey merged 2 commits intoremix-run:mainfrom
penx:firebase-rename-example
Aug 24, 2022
Merged

refactor(examples/firebase-auth-firestore): rename to firebase#4058
MichaelDeBoey merged 2 commits intoremix-run:mainfrom
penx:firebase-rename-example

Conversation

@penx
Copy link
Contributor

@penx penx commented Aug 24, 2022

As per

I'm fine having one sizeable example that's the one-stop example for all things firebase
#1811 (comment)

and

If you want, you can [rename the example] in another PR
#3398 (comment)

This PR renames the Firebase example to reflect it being for all things firebase.

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2022

⚠️ No Changeset found

Latest commit: 8db0d43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@penx penx changed the title Firebase rename example feat(examples/firebase): rename firebase example Aug 24, 2022
@MichaelDeBoey MichaelDeBoey changed the title feat(examples/firebase): rename firebase example refactor(examples/firebase-auth-firestore): rename to firebase Aug 24, 2022
@MichaelDeBoey MichaelDeBoey requested a review from machour August 24, 2022 17:00
@MichaelDeBoey MichaelDeBoey merged commit a16a83b into remix-run:main Aug 24, 2022
kayac-chang pushed a commit to kayac-chang/remix that referenced this pull request Sep 3, 2022
…ix-run#4058)

* git mv firebase-auth-firestore firebase

* Readme updates to reflect change to example name
freeman pushed a commit to freeman/remix that referenced this pull request Sep 7, 2022
…ix-run#4058)

* git mv firebase-auth-firestore firebase

* Readme updates to reflect change to example name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments