Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(remix-dev): replace xdm with @mdx-js/mdx v2 #4054

Merged
merged 8 commits into from
Aug 9, 2023

Conversation

jacobwgillespie
Copy link
Contributor

This PR addresses issue #1802 - xdm is now deprecated, and all functionality has been ported to @mdx-js/mdx.

Closes: #1802

  • Docs
  • Tests

Testing Strategy:

All existing tests pass with yarn test. Additionally, I created a playground and verified locally that mdx files still build as expected.

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

🦋 Changeset detected

Latest commit: 43d47a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 23, 2022

Hi @jacobwgillespie,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 23, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@belgattitude
Copy link

Thanks, deasync is very problematic on my side and even more with vercel and node 18.

Would be very nice to include in the next release 🙏

@machour
Copy link
Collaborator

machour commented Dec 2, 2022

@jacobwgillespie could you please rebase this on latest dev and fix conflicts? I'll try to get eyes on this PR.

@machour machour added the needs-response We need a response from the original author about this issue/PR label Dec 2, 2022
@machour machour changed the title Replace xdm with @mdx-js/mdx v2 chore(remix-dev): replace xdm with @mdx-js/mdx v2 Dec 2, 2022
@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Dec 2, 2022
@jacobwgillespie
Copy link
Contributor Author

@machour yep, rebased, thank you!

@MichaelDeBoey
Copy link
Member

@jacobwgillespie I didn't look into it, but there's also @mdx-js/esbuild
https://mdxjs.com/packages/esbuild

Could this replace our own esbuild plugin or do we need to keep this custom one?

@jacobwgillespie
Copy link
Contributor Author

Perhaps! I'm not super familiar with Remix's use of MDX internally, mostly just that xdm is deprecated and directly replaceable with @mdx-js/mdx.

@MichaelDeBoey
Copy link
Member

Hi @jacobwgillespie!

Are you still interested in getting this one merged?

If so, please rebase onto latest dev & resolve conflicts

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label May 1, 2023
@MichaelDeBoey MichaelDeBoey changed the title chore(remix-dev): replace xdm with @mdx-js/mdx v2 chore(remix-dev): replace xdm with @mdx-js/mdx v2 May 1, 2023
@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label May 2, 2023
@jacobwgillespie
Copy link
Contributor Author

@MichaelDeBoey Thanks for the ping, I have rebased onto the latest dev 👍

@jacobwgillespie
Copy link
Contributor Author

I'm not sure why the tests are failing, it's upset about packages/remix-dev/modules.ts which I don't think is affected by this PR.

@jacobwgillespie
Copy link
Contributor Author

Oh I see it, it's the new *.mdx types, let me take a look

@brophdawg11 brophdawg11 merged commit bec8703 into remix-run:dev Aug 9, 2023
8 of 9 checks passed
@jacobwgillespie jacobwgillespie deleted the mdxjs-2 branch August 9, 2023 16:48
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants