Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: windows testing updates #3915

Merged
merged 10 commits into from
Aug 5, 2022
Merged

test: windows testing updates #3915

merged 10 commits into from
Aug 5, 2022

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Aug 3, 2022

this PR does the following:

  • increase jest timeout on windows
  • fixes a cache issue where we'd always use the latest playwright version as the cache key
  • allows stacks + deployment tests to continue if one of them fails
  • enable playwright test retries locally so we can check for flakey tests
  • uses default workers based on machine config
  • mark upload test as slow
  • update playwright timeout on windows
  • enable fullyParallel

Closes: #

  • Docs
  • Tests

Testing Strategy:

CI and locally using Git Bash and PowerShell in windows terminal

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2022

⚠️ No Changeset found

Latest commit: c394ada

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh marked this pull request as ready for review August 3, 2022 18:41
@mcansh mcansh marked this pull request as draft August 3, 2022 23:17
@mcansh mcansh marked this pull request as ready for review August 5, 2022 17:46
@mcansh mcansh changed the title test: increase jest timeout on windows test: windows testing updates Aug 5, 2022
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 308bdf7 into main Aug 5, 2022
@kentcdodds kentcdodds deleted the logan/windows-jest-timeout branch August 5, 2022 23:34
@mcansh
Copy link
Collaborator Author

mcansh commented Aug 6, 2022

well that’s a positive start, first try it all worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants