Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add decision doc for remix router + react router 6.4 #3875

Merged
merged 13 commits into from
Oct 27, 2022
Merged

docs: add decision doc for remix router + react router 6.4 #3875

merged 13 commits into from
Oct 27, 2022

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Jul 29, 2022 •
edited
Loading

Started a decision doc to capture decisions made in the react-router 6.4.0 work. Just a rough first pass - comments welcome 😄

Preview

Github-md Preview 🔥

@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: b714b5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

machour
machour reviewed Jul 30, 2022
View reviewed changes
Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking 🤓

decisions/0004-remixing-react-router.md Outdated Show resolved Hide resolved
decisions/0004-remixing-react-router.md Outdated Show resolved Hide resolved
decisions/0004-remixing-react-router.md Outdated Show resolved Hide resolved
decisions/0004-remixing-react-router.md Outdated Show resolved Hide resolved
decisions/0004-remixing-react-router.md Outdated Show resolved Hide resolved
decisions/0004-remixing-react-router.md Outdated Show resolved Hide resolved
decisions/0004-remixing-react-router.md Outdated Show resolved Hide resolved
@machour machour added the docs label Jul 30, 2022
@kiliman kiliman mentioned this pull request Aug 3, 2022
Closed
@brophdawg11 brophdawg11 force-pushed the brophdawg11/router-decision-doc branch from 3cdee99 to 07bd4ba Compare September 6, 2022 20:55
@brophdawg11 brophdawg11 marked this pull request as ready for review September 6, 2022 20:55
machour
machour reviewed Sep 7, 2022
View reviewed changes
decisions/0005-remixing-react-router.md Outdated Show resolved Hide resolved
decisions/0005-remixing-react-router.md Outdated Show resolved Hide resolved
decisions/0005-remixing-react-router.md Outdated Show resolved Hide resolved
decisions/0005-remixing-react-router.md Outdated Show resolved Hide resolved
decisions/0005-remixing-react-router.md Outdated Show resolved Hide resolved
decisions/0005-remixing-react-router.md Outdated Show resolved Hide resolved
@brophdawg11 brophdawg11 merged commit d11fec0 into dev Oct 27, 2022
@brophdawg11 brophdawg11 deleted the brophdawg11/router-decision-doc branch October 27, 2022 13:45
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Oct 27, 2022
kentcdodds pushed a commit that referenced this pull request Dec 15, 2022
@brophdawg11 @machour
@Girish21 @kentcdodds
docs: add decision doc for remix router + react router 6.4 (#3875)
347399f 
Co-authored-by: Mehdi Achour <[email protected]>
Co-authored-by: Girish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girish21 Girish21 Girish21 left review comments

@abenhamdine abenhamdine abenhamdine left review comments

@sergiodxa sergiodxa sergiodxa left review comments

@machour machour machour left review comments

@kiliman kiliman kiliman left review comments

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@brophdawg11 @kiliman @machour @sergiodxa @MichaelDeBoey @abenhamdine @Girish21