Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-react): make actionData available in meta function #3534

Closed
wants to merge 1 commit into from

Conversation

kenneth-gray
Copy link

Hey folks 👋

Thought I'd give this a go as it didn't take long - no hard feelings if you feel it's the wrong way to go of course!

Things to consider:

  • As mentioned in the discussion I suspect it would be nicer to rename data => loaderData, but that's a breaking change to the API.
  • If data was renamed to loaderData, should parentsData be renamed to parentsLoaderData?
  • I started to wonder if the cookie header should also be made available (if it's not http only), so that if your strategy is to use session cookies for error messaging then you'd be able to access that too.

Closes: #3524

  • Docs
  • Tests

Testing Strategy:

This test covers this code: integration/meta-test.ts (added additional test)

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 21, 2022

Hi @kenneth-gray,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 21, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title feat: actionData available in the meta function feat(remix-react): make actionData available in meta function May 1, 2023
@MichaelDeBoey
Copy link
Member

Hi @kenneth-gray!

Are you still interested in getting this one merged?

If so, please rebase onto latest dev & resolve conflicts

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label May 1, 2023
@kenneth-gray
Copy link
Author

Yes very interested, will sort it out 👍

@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label May 3, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023

⚠️ No Changeset found

Latest commit: ae304b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kenneth-gray
Copy link
Author

Wanted to get the merge conflicts out of the way before sinking any more time into the PR.

@kenneth-gray
Copy link
Author

Will attempt to update changes into V2 and sort out all the testing as well. Probably won't be in a good position till the very end of the week.

@timkraut
Copy link
Contributor

timkraut commented Dec 6, 2023

@kenneth-gray Any update on this one? I'd happily help to get this over the finish line if there is anything I can do. I'm desperately looking for this feature

@kenneth-gray
Copy link
Author

@timkraut Feel free to take my contribution and make it your own. I ended up getting V1 working, but not finding the time to make it work for V2.

@kenneth-gray kenneth-gray closed this by deleting the head repository Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants