feat(remix-dev): support a TypeScript file for the remix.init index script
#2803
Conversation
|
Hi @dvargas92495, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
dvargas92495
force-pushed
the
RemixInitTs
branch
from
e6d021e
to
a99af03
Compare
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
| "create", | ||
| projectDir, | ||
| "--template", | ||
| path.join(__dirname, "fixtures", "stack-init-ts.tar.gz"), |
There was a problem hiding this comment.
I just copied the stack under /fixtures/stack, converting the index file to index.ts and console logging the message below in the default method exported
MichaelDeBoey
changed the title
remix.init index script
|
Hi @dvargas92495 and thank you for your submission! Can you rebase your PR against the |
dvargas92495
force-pushed
the
RemixInitTs
branch
2 times, most recently
from
3095dcc
to
51a57ec
Compare
|
Just rebased it! Sorry for not reading directions 🙈 |
| @@ -188,7 +188,8 @@ async function extractLocalTarball( | |||
| throw Error( | |||
| "🚨 There was a problem extracting the file from the provided template.\n\n" + | |||
| ` Template filepath: \`${filePath}\`\n` + | |||
| ` Destination directory: \`${projectDir}\`` | |||
| ` Destination directory: \`${projectDir}\`\n` + | |||
| ` ${err}` | |||
There was a problem hiding this comment.
This test is passing locally and failing on this error. Happy to remove this after I find out why it's failing on GH actions, but I think the error itself should be somewhere in this error message
|
hey @machour, could we run tests on this PR? Says I need a maintainer to approve running workflows. |
|
Okay this time I tar's the file with the script and ensure permissions were forgiving before tarring. Can we rerun the tests @machour? |
|
any insight on why I'm still getting eaccess permission errors? I'm just copying the existing |
|
@machour @MichaelDeBoey any thoughts on my question above? |
|
@dvargas92495 Could you please rebase on latest |
MichaelDeBoey
added
the
needs-response
|
I was just able to get the tests passing on my repo: dvargas92495#1, so I no longer need help getting unblocked. Going to rebase now and poke for review |
github-actions
bot
removed
the
needs-response
|
Ok rebased! @MichaelDeBoey could you run the tests? Turns out the failure was resolved by doing the same steps to tar the directory on a mac instead of a windows... 🤷 |
|
@dvargas92495 Tests seem to fail on CI. |
|
Whoops sorry! Left a typo on the rebase, could we rerun? |
|
Nice, @machour + @MichaelDeBoey PR is finally ready for review! |
|
Hey @mcansh, anything I could do on my end to get this ready for review? |
MichaelDeBoey
force-pushed
the
RemixInitTs
branch
from
e1acc3e
to
69feeca
Compare
dvargas92495
force-pushed
the
RemixInitTs
branch
from
69feeca
to
3eb2416
Compare
|
dvargas92495
force-pushed
the
RemixInitTs
branch
from
3eb2416
to
745ea29
Compare
dvargas92495
force-pushed
the
RemixInitTs
branch
from
745ea29
to
054ccfb
Compare
|
Hey @machour and @MichaelDeBoey I just rebased again could we get tests to run? Once they run, is there anything I could do to help get it reviewed? Should I open a discussion? Trying to get a sense of what the blockers are |
There was a problem hiding this comment.
Thank you for your hard work on this @dvargas92495. I'm a fan 👍 Thanks a bunch!
|
🤖 Hello there, We just published version Thanks! |
Closes: #
Sorry, I just decided to make the PR instead of making a discussion first. I don't mind if the PR gets declined and find PRs a better context for relevant discussion.
Docs
Tests
The goal for this PR is to support Typescript for the Remix Init Stack script. I plan to have a pretty hefty Init script for my custom stack, and want to avoid writing that in JavaScript.