Skip to content

ci: more nightly updates #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kentcdodds merged 2 commits into from
Apr 13, 2022
Merged

ci: more nightly updates #2780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1192af
chore: update nightly scripting
mcansh Apr 13, 2022
bed6fa3
Update nightly.yml
mcansh Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,16 @@ jobs:
echo ::set-output name=NEXT_VERSION::${NEXT_VERSION}

git checkout -b nightly/${NEXT_VERSION}
npm version ${NEXT_VERSION}

if [ -z "$(git status --porcelain)" ]; then
echo "✨"
else
echo "dirty working directory..."
git add .
git commit -m "dirty working directory..."
Comment on lines +55 to +57
Copy link
Copy Markdown
Member

@kentcdodds kentcdodds Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a dirty working directory? What steps trigger file changes?

Copy link
Copy Markdown
Contributor Author

@mcansh mcansh Apr 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great question, that i'd love to have an answer for!

the only files that change during the workflow are package.jsons after running our version script which are immediately committed, and that's done after this check 🤷

in my test repo i was getting a changed package-lock.json, but not sure what the dirtiness is here.

might be fine to leave the commit for a day and see if we can remove it tomorrow after we know what changed?

Copy link
Copy Markdown
Member

@kentcdodds kentcdodds Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

fi

yarn run version ${NEXT_VERSION} --skip-prompt

git push origin --tags

Expand Down
10 changes: 6 additions & 4 deletions scripts/version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,12 @@ async function run(args) {
}

// Confirm the next version number
let answer = await prompt(
`Are you sure you want to bump version ${currentVersion} to ${nextVersion}? [Yn] `
);
if (answer === false) return 0;
if (prereleaseId !== "--skip-prompt") {
let answer = await prompt(
`Are you sure you want to bump version ${currentVersion} to ${nextVersion}? [Yn] `
);
if (answer === false) return 0;
}

await incrementRemixVersion(nextVersion);
}
Expand Down