Remove instanceof check from isRouteErrorResponse #9930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8700348 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mcansh
approved these changes
Jan 18, 2023
MichaelDeBoey
approved these changes
Jan 18, 2023
machour
approved these changes
Jan 18, 2023
|
🤖 Hello there, We just published version Thanks! |
brophdawg11
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
github-actions
bot
removed
the
awaiting release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought we had removed all of these but looks like we missed one. Can't use
instanceofon non-primitives because depending on how server code is bundles/executed we can end up with an ESM and CJS instance of the class and these checks fail across the boundary.Closes remix-run/blues-stack#145