-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router): url encode file names #9867
Conversation
🦋 Changeset detectedLatest commit: 6f885d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7913b1f
to
e561e37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Just minor comments but I think this is otherwise in good shape
This is the RR port of remix-run/remix#4473 Bring FormData serialization in line with the spec with respect to File entries in url-encoded payloads: send the `name` as the value, as is the case with a vanilla `<form>` submission. Rework various 400-error tests not to rely on the old behavior, as it's no longer a bad request :) References: remix-run/remix#4342 Spec: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#convert-to-a-list-of-name-value-pairs
e561e37
to
bf281ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed feedback and rebased (errorMessage
stuff in router.ts had a conflict with a recent deferred change)
Thanks @jenseng! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
This is the RR port of remix-run/remix#4473
Bring FormData serialization in line with the spec with respect to File entries in url-encoded payloads: send the
name
as the value, as is the case with a vanilla<form>
submission.Rework various 400-error tests not to rely on the old behavior, as it's no longer a bad request :)
References: remix-run/remix#4342
Spec: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#convert-to-a-list-of-name-value-pairs