Fix: reset actionData on action redirect to current location #9772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 01f2351 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Dec 22, 2022
| state.navigation.state === "loading" && | ||
| state.navigation.formAction?.split("?")[0] === location.pathname; | ||
| location.state?._isRedirect !== true; |
There was a problem hiding this comment.
This was a naive way to look for "not a redirect" before, but now we have state._isRedirect since we did the Remix back compat layer which avoids false negatives on redirecting to the current location
jacob-ebey
approved these changes
Dec 22, 2022
mcansh
approved these changes
Dec 22, 2022
This was referenced Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9333
The tl;dr; is that there was a fix a long time ago to differentiate between action redirects and action reloads, but it gave false negatives if you redirected to the same location. We have a
state._isRedirectflag now that allows us to avoid this