Update replace logic for form submissions/redirects #9734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8e9747d The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Dec 15, 2022
Comment on lines
+828
to
+831
| if (userReplace === true) { | ||
| historyAction = HistoryAction.Replace; | ||
| } else if (userReplace === false) { | ||
| // no-op |
There was a problem hiding this comment.
Always respect the user value if provided
jacob-ebey
approved these changes
Dec 16, 2022
This was referenced Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes for PUSH/REPLACE logic for action submissions. The goal here is to be smart only when the user doesn't explicitly provide a
replacevalue. Currently we were missing respectingreplace:falsein the non-redirect scenario, so that is fixed in this PR.Furthermore, the new default logic is based on the location after the submission. If that location (be it from the
formActionor from aredirect) is the same as the current location, then we'llREPLACE, otherwise we'llPUSH