fix: reset actionData state on redirection from an action #9334
Conversation
🦋 Changeset detectedLatest commit: 53d58dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @jrakotoharisoa, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
packages/router/router.ts
Outdated
| @@ -951,6 +951,9 @@ export function createRouter(init: RouterInit): Router { | |||
| location: createLocation(state.location, result.location), | |||
| ...submission, | |||
| }; | |||
|
|
|||
| updateState({ actionData: null }); | |||
There was a problem hiding this comment.
We should try to do this in completeNavigation to avoid multiple calls of the subscriber. Can you see if the logic for isActionReload can be adjusted to account for this redirect use case? I'm unsure off the top of my head if that has access to enough information to deduce that this was a redirect after a successful action.
There was a problem hiding this comment.
Thanks, I remove this and add a condition to isActionReload to check if navigation location is different from the form action
There was a problem hiding this comment.
@brophdawg11, is it better now with the isActionReload logic adjusted ?
There was a problem hiding this comment.
Yep - thanks for the changes! I made a small update and added and extra test - I'll get this merged shortly 👍
This pull request is a fix for issue #9333
It removes the action data after a redirect from action.