fix: allow Framework Mode route components to be passed to createRoutesStub#14892
Merged
Conversation
…esStub Route components typed with Route.ComponentProps have more specific params and matches types. Due to TypeScript contravariance on function parameters, they were not assignable to React.ComponentType<RouteComponentProps>. Widen Component, HydrateFallback, and ErrorBoundary in StubRouteExtensions to React.ComponentType<any> so any route component can be passed without a type error. Fixes #14886 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: b716a56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
🤖 Hello there, We just published version Thanks! |
Contributor
|
🤖 Hello there, We just published version Thanks! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component,HydrateFallback, andErrorBoundaryinStubRouteExtensionswere typed asReact.ComponentType<RouteComponentProps>(and equivalents), which was too narrowFramework Mode components annotated with
Route.ComponentPropshave more specificparamsandmatchestypes — TypeScript's contravariance on function parameters means they aren't assignable to the broader typeWidening these to
React.ComponentType<any>fixes the type error while remaining safe at runtime, sincewithComponentPropsalways injects the correct props from router hooks regardless of the component's declared type.Fixes #14886