Fix percent encoding in relative path navigation#14786
Conversation
🦋 Changeset detectedLatest commit: 4d8ec43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @veeceey, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
veeceey
force-pushed
the
fix/issue-14510-percent-encoding
branch
from
f48505c to
c76ea73
Compare
|
Can you add a test for this logic and point this to the |
|
Hey @brophdawg11, good call on both counts. I'll add a test case for the percent encoding fix and retarget the PR to |
veeceey
force-pushed
the
fix/issue-14510-percent-encoding
branch
from
c76ea73 to
a7515b7
Compare
When navigating using relative links, path segments containing %25 (which decodes to %) were being left as raw % characters in the URI. This caused decoding failures and browser refresh issues. The fix adds encoding of % to %25 before encoding ? and # characters. The order is important to avoid double-encoding. Fixes remix-run#14510
veeceey
force-pushed
the
fix/issue-14510-percent-encoding
branch
from
a7515b7 to
4d8ec43
Compare
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
|
Fixed! thanks |
3 participants
Fixes #14510
When navigating using relative links, path segments containing %25 (percent) were being left as raw % characters, causing decoding failures and browser refresh issues.
This fix adds encoding of % to %25 before encoding ? and # characters in the useRoutesImpl hook. The order is important to avoid double-encoding.
Test results: 114 test suites passed, 2429 tests passed including params-decode-test.tsx