fix: clear timeout when turbo-stream encoding completes

[mcollina]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 1ebbd8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
react-router	Patch
@react-router/architect	Patch
@react-router/cloudflare	Patch
@react-router/dev	Patch
react-router-dom	Patch
@react-router/express	Patch
@react-router/node	Patch
@react-router/serve	Patch
@react-router/fs-routes	Patch
@react-router/remix-routes-option-adapter	Patch
create-react-router	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[remix-cla-bot]

Hi @mcollina,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[rossipedia]

question: Could this interact with AsyncLocalStorage in a way that could increase memory pressure during server request handlers?

I'm wrestling with high memory usage and keep coming across timers and streams in the heapsnapshots, wondering if this might be related.

[Jarrku]

We've had a memory leak issue on persistent node servers that seems to be resolved mostly after adding the following as a patch, not sure if it's related, was still profiling the patch ourselves before opening an issue.

 requestSignal.addEventListener("abort", () => clearTimeout(timeoutId), { once: true });

We also use AsyncLocalStorage, so might be somewhat related?

[mcollina]

question: Could this interact with AsyncLocalStorage in a way that could increase memory pressure during server request handlers?

I'm wrestling with high memory usage and keep coming across timers and streams in the heapsnapshots, wondering if this might be related.

Yes, this is it.

[mcollina]

Thanks @jacob-ebey!

[brophdawg11]

oops - this should have gone to dev, not main. gonna revert and cherry-pick to dev 👍

[github-actions]

🤖 Hello there,

We just published version 7.13.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 7.13.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!