Skip to content

Add docs and loosen origins wildcard check#14722

Merged
brophdawg11 merged 4 commits intodevfrom
brophdawg11/origins
Jan 15, 2026
Merged

Add docs and loosen origins wildcard check#14722
brophdawg11 merged 4 commits intodevfrom
brophdawg11/origins

Conversation

@brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Jan 13, 2026

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 59716a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

brophdawg11
brophdawg11 commented Jan 13, 2026
View reviewed changes
packages/react-router/lib/actions.ts
(patternParts[0] === "*" || patternParts[0] === "**")
) {
return false;
}
Copy link
Contributor Author

@brophdawg11 brophdawg11 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a overly restrictive and means that allowedActionOrigins: ["**"] doesn't work - which is pretty unintuitive

@brophdawg11 brophdawg11 mentioned this pull request Jan 15, 2026
Closed
@brophdawg11 brophdawg11 linked an issue Jan 15, 2026 that may be closed by this pull request
[Docs]: allowedOriginDomains takes in origin hosts excluding scheme #14723
Closed
@brophdawg11 brophdawg11 mentioned this pull request Jan 15, 2026
Merged
@brophdawg11 brophdawg11 merged commit f29c6c9 into dev Jan 15, 2026
9 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/origins branch January 15, 2026 16:36
@github-actions github-actions bot mentioned this pull request Jan 20, 2026
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

🤖 Hello there,

We just published version 7.13.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Jan 23, 2026
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

🤖 Hello there,

We just published version 7.13.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

edmundhung pushed a commit to edmundhung/react-router that referenced this pull request Jan 27, 2026
@brophdawg11 @edmundhung
Add docs and loosen origins wildcard check (remix-run#14722)
435a3b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed pkg:@react-router/dev pkg:react-router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Docs]: allowedOriginDomains takes in origin hosts excluding scheme

1 participant

@brophdawg11