Skip to content

Conversation

@rossipedia
Copy link
Contributor

@rossipedia rossipedia commented Jun 21, 2025

When calling atob(), a InvalidCharacterError DOMException is thrown if a character is encountered that is not allowed in Base64 encoding. When that happens, unsign() should just treat the signature as invalid instead of bubbling up that error

@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2025

🦋 Changeset detected

Latest commit: ff29649

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey linked an issue Jun 21, 2025 that may be closed by this pull request
@MichaelDeBoey MichaelDeBoey changed the title Treat cookie signatures with invalid encodings as invalid feat(react-router/server-runtime): treat cookie signatures with invalid encodings as invalid Jun 21, 2025
Hardanish-Singh

This comment was marked as spam.

Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you mind adding a changeset so we can get this merged?

@brophdawg11 brophdawg11 merged commit 3f49a36 into remix-run:dev Jun 25, 2025
5 checks passed
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid characters in cookie signature throws a DOMException

5 participants