- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10.7k
feat(react-router/server-runtime): treat cookie signatures with invalid encodings as invalid #13847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-router/server-runtime): treat cookie signatures with invalid encodings as invalid #13847
Conversation
| 🦋 Changeset detectedLatest commit: ff29649 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
 Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Do you mind adding a changeset so we can get this merged?
| 🤖 Hello there, We just published version  Thanks! | 
| 🤖 Hello there, We just published version  Thanks! | 
When calling
atob(), aInvalidCharacterErrorDOMExceptionis thrown if a character is encountered that is not allowed in Base64 encoding. When that happens,unsign()should just treat the signature as invalid instead of bubbling up that error