-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fs folders routes #12648
base: dev
Are you sure you want to change the base?
Fs folders routes #12648
Conversation
|
Hi @okalil, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Could you look at also porting over the test from here? https://github.com/remix-run/v1-compat-utils/blob/main/packages/v1-route-convention/__tests__/index-test.ts
* naming](https://remix.run/docs/en/v1/file-conventions/routes-files), for use | ||
* within `routes.ts`. | ||
*/ | ||
export async function foldersRoutes(): Promise<RouteConfigEntry[]> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rename this to nestedRoutes
?
Also, similar to the flatRoutes
function above, could you make this accept a "rootDirectory" option, and use getAppDirectory
internally to resolve the app directory from the user's config? Right now the app/routes
directory is hard coded but this should be configurable.
Closes #12647