-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for replace() redirects #11811
Conversation
🦋 Changeset detectedLatest commit: cbf49e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
export const replace: RedirectFunction = (url, init) => { | ||
let response = redirect(url, init); | ||
response.headers.set("X-Remix-Replace", "true"); | ||
return response; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to redirectDocument
- this is just a wrapper with a custom internal header
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
I gave it a try, but it does not quite behave like I would have expected. Not sure though if this is a misunderstanding on my side or a bug. Minimal reproduction: https://stackblitz.com/edit/github-efe1i6?file=src%2Fapp.tsx Steps to reproduce:
Expected Actual @brophdawg11 Could you take a look whether this is expected? |
This is functioning as expected because loaders run before the history stack is updated. So the loader for If you want the history stack to be |
Builds off of #11100 and adds the new
replace()
redirect APICloses #10606