-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger a new router.routes identity during fog of war route patching #11740
Conversation
🦋 Changeset detectedLatest commit: 0b4f1bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
// HMR will already update the identity and reflow when it lands | ||
// `inFlightDataRoutes` in `completeNavigation` | ||
if (isNonHMR) { | ||
dataRoutes = [...dataRoutes]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update router.routes
identity during normal navigation discovery via unstable_patchRoutesOnMiss
if (isNonHMR) { | ||
dataRoutes = [...dataRoutes]; | ||
updateState({}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update router.routes
identity and reflow during eager router.patchRoutes
flows
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
This lets anything memoized via on
router.routes
update - such as Remix<Link prefetch>
prefetching behavior - which will not prefetch initially, but will prefetch once the route has been discovered