Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow undefined to be resolved with <Await> #11513

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

jacob-ebey
Copy link
Member

@jacob-ebey jacob-ebey commented Apr 29, 2024

Copy link

changeset-bot bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: dfc66df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jacob-ebey jacob-ebey marked this pull request as ready for review April 29, 2024 17:30
@brophdawg11
Copy link
Contributor

Discussed in discord but this is good to merge since it wont change defer behavior because defer already rejects with an error if you resolve with undefined (Deferred data for key ... resolved/rejected with undefined, you must resolve/reject with a value or null).

We want to align the behavior behind the single fetch flag for the next major version and stop throwing on returning undefined from a loader since we have no issues serializing that now (as opposed to when we were using JSON.stringify)

@jacob-ebey jacob-ebey merged commit e0b1db4 into dev Apr 29, 2024
3 checks passed
@jacob-ebey jacob-ebey deleted the await_undefined branch April 29, 2024 19:13
Copy link
Contributor

🤖 Hello there,

We just published version 6.23.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.23.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants