Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert useResolvedPath fix in splat routes #11078

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

brophdawg11
Copy link
Contributor

Reverts #10983 (+ f320378) and #11045.

We discovered that a large number of existing applications were relying on the buggy behavior that these fixed so we decided to revert the fix and we will re-release it behind a future flag so folks can opt-in (see #11052 (comment))

Original issue: #10922
Closes: #11052
Related: #11053, #11067, #11070, #11074

Copy link

changeset-bot bot commented Dec 1, 2023

🦋 Changeset detected

Latest commit: f29d6f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
react-router-dom Patch
react-router Patch
@remix-run/router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit 9cfd99d into dev Dec 1, 2023
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/revert-resolve-path-fix branch December 1, 2023 19:07
Copy link
Contributor

github-actions bot commented Dec 1, 2023

🤖 Hello there,

We just published version 6.20.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Dec 1, 2023

🤖 Hello there,

We just published version 6.20.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant