wip: initial fetchStrategy #11001
wip: initial fetchStrategy #11001
Conversation
|
| @@ -339,6 +339,23 @@ export type HydrationState = Partial< | |||
| Pick<RouterState, "loaderData" | "actionData" | "errors"> | |||
| >; | |||
|
|
|||
| export interface DefaultCallLoaderOrActionFunction { | |||
| ( | |||
| type: "loader" | "action", | |||
There was a problem hiding this comment.
Does this need to call actions? I've been envisioning this as a loader-only concept
| import { json } from "../index"; | ||
| import { cleanup, setup } from "./utils/data-router-setup"; | ||
| import { createFormData } from "./utils/utils"; | ||
|
|
||
| let fetchStrategy: FetchStrategy; | ||
| beforeEach(() => { | ||
| fetchStrategy = jest.fn( |
There was a problem hiding this comment.
Do we need to provide the default and update all the existing tests? Since fetchStrategy will be a net-new optional prop, I think we should be able to leave all existing tests untouched and then add a few tests that set it accordingly?
describe('fetchStrategy', () => {
it('fetches in parallel if no fetchStrategy is provided', ...);
it('allows users to re-implement the default parallel fetching via Promise.all/defaultCallLoader', ...);
it('allows users to implement a custom fetch strategy (single-fetch)', ...);
it('allows users to implement a custom fetch strategy (composing gql fragments from handle)', ...);
});
|
Superseded by #11098 |
No description provided.