Ensure Form contains splat portion of pathname when no action is specified #10933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 950853f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Oct 13, 2023
| @@ -2894,7 +2894,7 @@ function testDomRouter( | |||
| let { container } = render(<RouterProvider router={router} />); | |||
|
|
|||
| expect(container.querySelector("form")?.getAttribute("action")).toBe( | |||
| "/foo?a=1" | |||
| "/foo/bar?a=1" | |||
There was a problem hiding this comment.
This test was previously asserting the incorrect behavior
jacob-ebey
approved these changes
Oct 13, 2023
This was referenced Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
actionfor<Form>when noactionis specified was being calculated viauseResolvedPath("."), however that only includes thepathnameBaseso we were losing the splat value.Given
{ path: '/foo/*' }, and accessing/foo/bar/baz,<Form>would incorrectly render<Form action="/foo">.This PR updates the default form action to be
useResolvedPath(location.pathname)so we render<Form action="/foo/bar/baz">Closes #10922