Add generics for Remix type enhancements #10843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 25622d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
force-pushed
the
brophdawg11/align-types
branch
from
fef17cb
to
ea5a5f2
Compare
brophdawg11
commented
Sep 5, 2023
| params: AgnosticRouteMatch["params"]; | ||
| data: unknown; | ||
| handle: unknown; | ||
| } |
There was a problem hiding this comment.
This is now exported from utils.ts as UIMatch
|
🤖 Hello there, We just published version Thanks! |
| /** | ||
| * An entry in a history stack. A location contains information about the | ||
| * URL path, as well as possibly some arbitrary state and a key. | ||
| */ | ||
| export interface Location extends Path { | ||
| export interface Location<S = any> extends Path { |
There was a problem hiding this comment.
Suggested change
| export interface Location<S = any> extends Path { | |
| export interface Location<State = any> extends Path { |
| /** | ||
| * Arguments passed to loader functions | ||
| */ | ||
| export interface LoaderFunctionArgs extends DataFunctionArgs {} | ||
| export interface LoaderFunctionArgs<C = any> extends DataFunctionArgs<C> {} |
There was a problem hiding this comment.
Suggested change
| export interface LoaderFunctionArgs<C = any> extends DataFunctionArgs<C> {} | |
| export interface LoaderFunctionArgs<Context = any> extends DataFunctionArgs<Context> {} |
|
|
||
| /** | ||
| * Arguments passed to action functions | ||
| */ | ||
| export interface ActionFunctionArgs extends DataFunctionArgs {} | ||
| export interface ActionFunctionArgs<C = any> extends DataFunctionArgs<C> {} |
There was a problem hiding this comment.
Suggested change
| export interface ActionFunctionArgs<C = any> extends DataFunctionArgs<C> {} | |
| export interface ActionFunctionArgs<Context = any> extends DataFunctionArgs<Context> {} |
Comment on lines
+169
to
+170
| export interface LoaderFunction<C = any> { | ||
| (args: LoaderFunctionArgs<C>): Promise<DataFunctionValue> | DataFunctionValue; |
There was a problem hiding this comment.
Suggested change
| export interface LoaderFunction<C = any> { | |
| (args: LoaderFunctionArgs<C>): Promise<DataFunctionValue> | DataFunctionValue; | |
| export interface LoaderFunction<Context = any> { | |
| (args: LoaderFunctionArgs<Context>): Promise<DataFunctionValue> | DataFunctionValue; |
Comment on lines
+176
to
+177
| export interface ActionFunction<C = any> { | ||
| (args: ActionFunctionArgs<C>): Promise<DataFunctionValue> | DataFunctionValue; |
There was a problem hiding this comment.
Suggested change
| export interface ActionFunction<C = any> { | |
| (args: ActionFunctionArgs<C>): Promise<DataFunctionValue> | DataFunctionValue; | |
| export interface ActionFunction<Context = any> { | |
| (args: ActionFunctionArgs<Context>): Promise<DataFunctionValue> | DataFunctionValue; |
| @@ -490,6 +493,28 @@ export function matchRoutes< | |||
| return matches; | |||
| } | |||
|
|
|||
| export interface UIMatch<D = unknown, H = unknown> { | |||
There was a problem hiding this comment.
Suggested change
| export interface UIMatch<D = unknown, H = unknown> { | |
| export interface UIMatch<Data = unknown, Handle = unknown> { |
Comment on lines
+500
to
+501
| data: D; | ||
| handle: H; |
There was a problem hiding this comment.
Suggested change
| data: D; | |
| handle: H; | |
| data: Data; | |
| handle: Handle; |
|
🤖 Hello there, We just published version Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding TS generics to support remix-run/remix#7319