Skip to content

Conversation

@jaschaio
Copy link

See #9978

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

⚠️ No Changeset found

Latest commit: 91a922e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 11, 2023

Hi @jaschaio,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 11, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@jaschaio jaschaio closed this by deleting the head repository Oct 23, 2023
@cjsilva-umich
Copy link

Just curious as to why this was never merged in.

@Virthuss
Copy link

Just curious as to why this was never merged in.

Agree. I need this as in my current situation I need multiple instances of blocker. Will this be merged anytime soon ? Thanks in advance !

@nivnahmias
Copy link

nivnahmias commented Aug 7, 2024

Can this pr please be addressed?
@brophdawg11
The code comments say that "we don't have any compelling use cases for multi-blocker yet" when in fact we do.
the solution seems very simple and works consistently in production apps that have patched/forked the main repo.
I'm just not sure why there hasn't been any discourse regarding this issue. suggesting devs "hoist" up the predicate for the hook is simply not practical in any large scale app.
I would appreciate some help with this issue 🙏

@jaschaio
Copy link
Author

How would I know? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants