Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional path segments in matchPath #10768

Conversation

imjordanxd
Copy link
Contributor

Overview

Adds support for optional path segments in matchPath. Resolves #9862

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

🦋 Changeset detected

Latest commit: 3092148

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Minor
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 8, 2023

Hi @imjordanxd,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 9, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@imjordanxd
Copy link
Contributor Author

Hey, @brophdawg11 👋 can you review this? I know some people (including myself) are patiently awaiting this fix

@imjordanxd imjordanxd force-pushed the jordant/matchPath-support-optional-segments branch from cb79874 to 6ee04ff Compare August 22, 2023 02:45
@imjordanxd imjordanxd force-pushed the jordant/matchPath-support-optional-segments branch from 6ee04ff to a09a55a Compare September 13, 2023 21:54
@imjordanxd
Copy link
Contributor Author

Hi, @timdorr 👋 is someone else able to review this PR?

@brophdawg11
Copy link
Contributor

I apologize for the delay - we will get to this when we have some more bandwidth. We've been heads down on getting Remix v2 prepped and released recently.

@imjordanxd imjordanxd force-pushed the jordant/matchPath-support-optional-segments branch from a09a55a to bf2bf62 Compare October 18, 2023 05:20
@imjordanxd imjordanxd force-pushed the jordant/matchPath-support-optional-segments branch from bf2bf62 to 2d0b110 Compare October 18, 2023 05:21
@brophdawg11
Copy link
Contributor

Thanks for the PR!

@brophdawg11 brophdawg11 merged commit 677d6c8 into remix-run:dev Oct 20, 2023
3 checks passed
@Syed-Ali-Abbas-Zaidi
Copy link

Hi @brophdawg11, When will this be released?

@brophdawg11
Copy link
Contributor

In the next release, I can't provide a specific time, but hopefully next week or two

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.18.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.18.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants