Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isQueryRouteResponse #10703

Merged

Conversation

daniilguit
Copy link
Contributor

Fix typo during check in isQueryRouteResponse

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2023

⚠️ No Changeset found

Latest commit: 6d1de5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 14, 2023

Hi @daniilguit,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 14, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@timdorr
Copy link
Member

timdorr commented Jul 15, 2023

Can we add a test for this so we don't have a regression later?

@brophdawg11 brophdawg11 self-assigned this Jul 17, 2023
@brophdawg11 brophdawg11 changed the base branch from main to dev July 19, 2023 12:23
@brophdawg11 brophdawg11 changed the base branch from dev to main July 19, 2023 12:24
@brophdawg11
Copy link
Contributor

Thanks for the PR @daniilguit! Since this has code changes, I'm going to merge it to a branch of mine so I can get it rebased onto dev and add a few unit tests 👍

@brophdawg11 brophdawg11 changed the base branch from main to brophdawg11/isqueryrouteresponse July 19, 2023 12:27
@brophdawg11 brophdawg11 merged this pull request into remix-run:brophdawg11/isqueryrouteresponse Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants