Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not short circuit loaders on initial load when hash is present #10493

Merged
merged 1 commit into from
May 16, 2023

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented May 15, 2023

On initial load if we have loaders to run and we call startNavigation, state.location and location are the same so if we have a hash we don't want to incorrectly decide it's a hash-change-only navigation. So only short circuit once the router has been initialized.

Closes #10469

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

🦋 Changeset detected

Latest commit: 9d88448

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IsaacInsoll
Copy link

Thank you so much for this, we were experiencing this exact issue!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.11.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.11.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Using hash with lazy component results in an empty page on initial load
5 participants