🗺 Alternate submission encodings #10413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)"" This reverts commit f92aa2e.
🦋 Changeset detectedLatest commit: e22ec53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
changed the title
brophdawg11
changed the title
brophdawg11
commented
Jun 1, 2023
| submit({ key: "value" }); | ||
| // navigation.formEncType => "application/x-www-form-urlencoded" | ||
| // navigation.formData => FormData instance | ||
| // navigation.text => "key=value" |
There was a problem hiding this comment.
Let's consider making text/formData/json all mutually exclusive to avoid buffering large bodies in memory
brophdawg11
force-pushed
the
brophdawg11/better-actions
branch
from
886716c
to
253cca7
Compare
brophdawg11
force-pushed
the
brophdawg11/better-actions
branch
from
303e7af
to
d849944
Compare
Merged
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
MichaelDeBoey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated approach for #10324
Note: inline fetcher
loader/actionsupport was removed and this is trimmed to just add json/textencTypesupport. We need to figure out how react form actions impact the submit/fetcher API in this and Remix.TODO:
useSubmit(only allowed onfetcher.submit)encTypeis limited to browser behavior on<Form>/<fetcher.Form>