-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow useRevalidate to resolve a loader-driven error boundary UI #10369
Conversation
🦋 Changeset detectedLatest commit: ba2e981 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
expect(html).toMatch("Unexpected Application Error!"); | ||
expect(html).toMatch("404 Not Found"); | ||
expect(html).toMatch("💿 Hey developer 👋"); | ||
expect(html).not.toMatch(/stack/i); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was getting some weird snapshot whitespace failures here so moved to just assert the important aspects of the default UI
if ( | ||
state.location !== props.location || | ||
(state.revalidation !== "idle" && props.revalidation === "idle") | ||
) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we leave and return to revalidation:idle
we let props drive the UI again
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Closes #9713