Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow useRevalidate to resolve a loader-driven error boundary UI #10369

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

brophdawg11
Copy link
Contributor

Closes #9713

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2023

🦋 Changeset detected

Latest commit: ba2e981

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Apr 18, 2023 that may be closed by this pull request
expect(html).toMatch("Unexpected Application Error!");
expect(html).toMatch("404 Not Found");
expect(html).toMatch("💿 Hey developer 👋");
expect(html).not.toMatch(/stack/i);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was getting some weird snapshot whitespace failures here so moved to just assert the important aspects of the default UI

if (
state.location !== props.location ||
(state.revalidation !== "idle" && props.revalidation === "idle")
) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we leave and return to revalidation:idle we let props drive the UI again

@brophdawg11 brophdawg11 merged commit fda0123 into dev Apr 21, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/revalidate-error-boundary branch April 21, 2023 20:19
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.11.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.11.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: useRevalidator doesn't clear route errors
4 participants