Fail gracefully on invalid Link to values #10367
Conversation
🦋 Changeset detectedLatest commit: f533024 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| isExternal = true; | ||
| } | ||
| } catch (e) { | ||
| // We can't do external URL detection without a valid URL |
There was a problem hiding this comment.
useful to check whether e instanceof TypeError or rethrow? https://developer.mozilla.org/en-US/docs/Web/API/URL/URL#exceptions
There was a problem hiding this comment.
Part of the goal here is that a broken link is better than a crashed render (see remix-run/remix#5440 (comment)), so I don't think re-throwing is what we want to do.
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Closes remix-run/remix#5440