New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper 404 error for missing loader #10345

Merged

brophdawg11 merged 1 commit into dev from brophdawg11/fetcher-404s

Apr 14, 2023

Contributor

brophdawg11 commented Apr 14, 2023 •

edited

Loading

Add a proper 404 ErrorResponse for a fetcher.load to a route without a loader, instead of a raw Error


          Add proper 404 error for missing loader

a11f18b

changeset-bot bot commented Apr 14, 2023

🦋 Changeset detected

Latest commit: a11f18b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@remix-run/router	Patch
react-router	Patch
react-router-dom	Patch
react-router-dom-v5-compat	Patch
react-router-native	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

remix-cla-bot bot added the CLA Signed label

brophdawg11 commented

View reviewed changes

packages/router/router.ts

                         throw getInternalRouterError(405, {
                           method: request.method,
-                          pathname: new URL(request.url).pathname,
+                          pathname,

Contributor Author

brophdawg11 Apr 14, 2023

Added the search here to align with the new error below since ?index may be relevant

brophdawg11 commented

View reviewed changes

packages/router/router.ts

-                      handler,
-                      `Could not find the ${type} to run on the "${match.route.id}" route`
-                    );

Contributor Author

brophdawg11 Apr 14, 2023

Switch to a 404 ErrorResponse instead of a raw Error

brophdawg11 assigned mcansh and jacob-ebey

mcansh approved these changes

View reviewed changes

jacob-ebey approved these changes

View reviewed changes

brophdawg11 merged commit 0685cd9 into dev

brophdawg11 deleted the brophdawg11/fetcher-404s branch

April 14, 2023 19:05

MichaelDeBoey added the router label

github-actions bot mentioned this pull request

chore: Update version for release (pre) #10398

Merged

Contributor

github-actions bot commented Apr 26, 2023

🤖 Hello there,

We just published version 6.11.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions bot mentioned this pull request

chore: Update version for release #10414

Merged

Contributor

github-actions bot commented Apr 28, 2023

🤖 Hello there,

We just published version 6.11.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed router