Skip to content

Commit

Permalink
Escape PKG_CHECK_MODULES (VirusTotal#1540)
Browse files Browse the repository at this point in the history
* Escape `PKG_CHECK_MODULES`

This small changes allows to fix an issues avast/retdec#990 and probably VirusTotal#1171

The root cause of this issues is different shell which is used. Some simple shell like dsh I belive can't survive on this line without escaping, some modern like bash easly can.

Thus at § 3.5 at https://autotools.io/pkgconfig/pkg_check_modules.html it is cleare suggested to escape by `[...]`.

* Escape `protobuf-c`
  • Loading branch information
catap authored and maximelb committed Nov 17, 2022
1 parent 8b8f914 commit f1a293b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ AC_ARG_ENABLE([pb-tests],
# AC_CHECK_PROG(PROTOC_GEN_YARA, protoc-gen-yara, protoc-gen-yara)
# AS_IF([test "x${PROTOC_GEN_YARA}" == "x"],
# [AC_MSG_ERROR([please install https://github.com/VirusTotal/protoc-gen-yara])])
PKG_CHECK_MODULES(PROTOBUF_C, libprotobuf-c >= 1.0.0)
AC_CHECK_LIB(protobuf-c, protobuf_c_message_unpack,,
PKG_CHECK_MODULES([PROTOBUF_C], [libprotobuf-c >= 1.0.0])
AC_CHECK_LIB([protobuf-c], protobuf_c_message_unpack,,
AC_MSG_ERROR([please install libprotobuf-c library]))
CFLAGS="$CFLAGS -DPB_TESTS_MODULE"
PC_REQUIRES_PRIVATE="$PC_REQUIRES_PRIVATE libprotobuf-c"
Expand Down

0 comments on commit f1a293b

Please sign in to comment.